[Transaction] add method to clear up transaction buffer snapshot #11934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
requested review from
congbobo184,
eolivelli,
315157973 and
codelipenghui
315157973
approved these changes
Sep 6, 2021
| txn.commit().get(); | ||
|
|
||
| // wait for take snapshot | ||
| Thread.sleep(1000 * 3); |
There was a problem hiding this comment.
Can we trigger the snapshot manually? this might introduce a flaky test in the CI enviroment.
codelipenghui
approved these changes
Sep 7, 2021
eolivelli
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
LGTM
@codelipenghui why you added 2.8.2 label ?
This looks like a new (internal) feature.
We should not port commits to a "stable" branch if not strictly needed. Otherwise we risk to compromise stability.
codelipenghui
pushed a commit
that referenced
this pull request
Sep 9, 2021
) (cherry picked from commit d86db3f)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the transaction buffer didn't support clear up the snapshot, if delete the topic the snapshot will not be deleted.
refer to #11928
Modifications
Clear up the transaction buffer snapshot when deleting the topic.
Verifying this change
Add a test to verify the snapshot was clear up or not.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)