[C++] Handle error when shutting down client after forks #11954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/enhancement
merlimat
requested review from
rdhabalia,
jerrypeng,
hangc0276,
codelipenghui and
BewareMyPower
BewareMyPower
approved these changes
Sep 8, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Sep 9, 2021
* [C++] Handle error when shutting down client after forks * Fixed formatting (cherry picked from commit 2858ed0)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* [C++] Handle error when shutting down client after forks * Fixed formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #11953
After a
fork()call, the threads are not getting ported to the child process (at least not most of them). When we're shutting down the pulsar client, we should handle the exceptionI didn't add a specific error check since there's no portable error code to be used.