Force Python CI to use earlier version of Protobuf which supports Python2 #12058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
area/test
area/build
component/python
doc-not-needed
merlimat
requested review from
rdhabalia,
hangc0276,
aahmed-se,
eolivelli and
BewareMyPower
aahmed-se
approved these changes
Sep 16, 2021
sijie
approved these changes
Sep 16, 2021
merlimat
added a commit
that referenced
this pull request
Sep 16, 2021
codelipenghui
added
release/2.8.2
cherry-picked/branch-2.8
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
Nov 4, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The C++/Python CI job is currently broken after a Protobuf update was pushed to PyPI: https://pypi.org/project/protobuf/#history
Protobuf 3.18 doesn't work anymore on Py2 and our CI for Python is still running on Py2. For now, let's pin the Protobuf version, later we need to eradicate Py2 from the codebase.