Fix k8s pulsar functions containers not exposing metrics port for scraping #12065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their metrics port for scraping
|
@sijie would you mind approving the workflows/tests to be run? 🙏 |
|
can this be reviewed/merged? |
eolivelli
requested review from
codelipenghui,
jerrypeng,
merlimat and
rdhabalia
|
Closing and reopening to trigger CI. All of the tests are in "Expected" state. I haven't seen this happen before. |
|
Alright, tests are listed as "Queued", so they should run. |
|
/pulsarbot run-failure-checks |
|
Unfortunately, we have some flaky tests. The test that failed is not related to this change. Re-running the failed test. |
lhotari
approved these changes
Dec 3, 2021
michaeljmarshall
added
cherry-picked/branch-2.8
michaeljmarshall
pushed a commit
that referenced
this pull request
Dec 3, 2021
(cherry picked from commit 4dd4bd6)
michaeljmarshall
added
the
type/enhancement
michaeljmarshall
pushed a commit
that referenced
this pull request
Dec 3, 2021
(cherry picked from commit 4dd4bd6)
|
@volgorean - thanks for your contribution! I cherry picked it to the relevant branches. |
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 3, 2021
(cherry picked from commit 4dd4bd6)
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
getFunctionContainerPortsto return both its grpc port as well as the metric port (currently the function returning the metrics port in its own list is not being called)Verifying this change
This change added tests and can be verified as follows:
Documentation