Remove the deprecated api usage in hdfs #12080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hangc0276 PTAL |
codelipenghui
approved these changes
Sep 22, 2021
|
@merlimat @eolivelli PTAL |
BewareMyPower
requested changes
Sep 23, 2021
pulsar-io/hdfs2/src/main/java/org/apache/pulsar/io/hdfs2/AbstractHdfsConnector.java
Outdated
Show resolved
Hide resolved
|
LGTM, just left a comment for the code format. |
…actHdfsConnector.java Co-authored-by: Yunze Xu <xyzinfernity@163.com>
Fixed, PTAL |
BewareMyPower
approved these changes
Sep 23, 2021
|
@shoothzj You can use |
|
/pulsarbot run-failure-checks |
hangc0276
approved these changes
Sep 26, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Sep 29, 2021
### Motivation Remove the deprecated api usage in hdfs ### Modifications Use try with resources instead of closeQuitely Remove the Long constructor * Remove the deprecated api usage in hdfs * Update pulsar-io/hdfs2/src/main/java/org/apache/pulsar/io/hdfs2/AbstractHdfsConnector.java Co-authored-by: Yunze Xu <xyzinfernity@163.com> Co-authored-by: Yunze Xu <xyzinfernity@163.com> (cherry picked from commit f822016)
codelipenghui
pushed a commit
that referenced
this pull request
Dec 11, 2021
### Motivation Remove the deprecated api usage in hdfs ### Modifications Use try with resources instead of closeQuitely Remove the Long constructor * Remove the deprecated api usage in hdfs * Update pulsar-io/hdfs2/src/main/java/org/apache/pulsar/io/hdfs2/AbstractHdfsConnector.java Co-authored-by: Yunze Xu <xyzinfernity@163.com> Co-authored-by: Yunze Xu <xyzinfernity@163.com> (cherry picked from commit f822016)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation Remove the deprecated api usage in hdfs ### Modifications Use try with resources instead of closeQuitely Remove the Long constructor * Remove the deprecated api usage in hdfs * Update pulsar-io/hdfs2/src/main/java/org/apache/pulsar/io/hdfs2/AbstractHdfsConnector.java Co-authored-by: Yunze Xu <xyzinfernity@163.com> Co-authored-by: Yunze Xu <xyzinfernity@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove the deprecated api usage in hdfs
Modifications
Use try with resources instead of
closeQuitelyRemove the Long constructor
Documentation
little internal optimization