Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] Make python3 the default python in java-test-image #12130

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Sep 22, 2021

Motivation

The java-test-image docker image is broken. It has been broken since the base image was changed to ubuntu:20.04 .
python3 should be default for the image to work .
java-test-image isn't currently used in Pulsar CI. It could be used to run integration tests that don't require Pulsar SQL / Presto or other parts that are outside of the core-modules profile.

Modifications

  • make python3 the default
  • install python3-yaml instead of python-yaml package

@lhotari lhotari added the type/bug The PR fixed a bug or issue reported a bug label Sep 22, 2021
@lhotari lhotari added this to the 2.9.0 milestone Sep 22, 2021
@lhotari lhotari self-assigned this Sep 22, 2021
@lhotari lhotari added the doc-not-needed Your PR changes do not impact docs label Sep 22, 2021
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@eolivelli
Copy link
Contributor

I have merged the doc bot.
But it does not work

@Anonymitaet please help

@eolivelli
Copy link
Contributor

@lhotari please rebase on current master, the Doc Bot should disappear

- python3 should be default for the image to work
- this has been broken since the base image was changed to ubuntu:20.04
@lhotari lhotari force-pushed the lh-fix-java-test-image-python3-default branch from a5b5f44 to 8c860ce Compare September 23, 2021 12:28
@lhotari
Copy link
Member Author

lhotari commented Sep 23, 2021

@eolivelli rebased now

@lhotari lhotari merged commit 4ac228d into apache:master Oct 1, 2021
codelipenghui pushed a commit that referenced this pull request Oct 6, 2021
- python3 should be default for the image to work
- this has been broken since the base image was changed to ubuntu:20.04

(cherry picked from commit 4ac228d)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Oct 6, 2021
lhotari added a commit to datastax/pulsar that referenced this pull request Dec 22, 2021
…12130)

- python3 should be default for the image to work
- this has been broken since the base image was changed to ubuntu:20.04

(cherry picked from commit 4ac228d)
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…12130)

- python3 should be default for the image to work
- this has been broken since the base image was changed to ubuntu:20.04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.0 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants