[ISSUE-12291][Client] 'StartMessageId' and 'RollbackDuration' not working in MultiTopicsReader for non-partitioned topics #12308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please modify the check |
gaoran10
requested review from
codelipenghui,
congbobo184,
hangc0276 and
zymap
Done. |
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
added 2 commits
October 18, 2021 10:25
…in MultiTopicsReader for non-partitioned topic
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Nov 4, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Nov 5, 2021
…king in MultiTopicsReader for non-partitioned topics (#12308) Fixes #12291 ### Motivation Bug fix. 'StartMessageId' and 'RollbackDuration' is not working in MultiTopicsReader for non-partitioned topics. ### Modifications This fix is quite simple. Just add `startMessageId` and `startMessageRollbackDurationInSec` when creating underlying consumer with `ConsumerImpl.newConsumerImpl` (cherry picked from commit cb48152)
eolivelli
pushed a commit
that referenced
this pull request
Nov 9, 2021
…king in MultiTopicsReader for non-partitioned topics (#12308) Fixes #12291 ### Motivation Bug fix. 'StartMessageId' and 'RollbackDuration' is not working in MultiTopicsReader for non-partitioned topics. ### Modifications This fix is quite simple. Just add `startMessageId` and `startMessageRollbackDurationInSec` when creating underlying consumer with `ConsumerImpl.newConsumerImpl` (cherry picked from commit cb48152)
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…king in MultiTopicsReader for non-partitioned topics (apache#12308) Fixes apache#12291 ### Motivation Bug fix. 'StartMessageId' and 'RollbackDuration' is not working in MultiTopicsReader for non-partitioned topics. ### Modifications This fix is quite simple. Just add `startMessageId` and `startMessageRollbackDurationInSec` when creating underlying consumer with `ConsumerImpl.newConsumerImpl`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12291
Motivation
Bug fix. 'StartMessageId' and 'RollbackDuration' is not working in MultiTopicsReader for non-partitioned topics.
Modifications
This fix is quite simple. Just add
startMessageIdandstartMessageRollbackDurationInSecwhen creating underlying consumer withConsumerImpl.newConsumerImplVerifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc
(Please explain why) simple bug fix.