useV2WireProtocol for bookkeeper autorecovery #12311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
added
release/2.8.2
component/bookkeeper
type/enhancement
zymap
approved these changes
Oct 11, 2021
codelipenghui
approved these changes
Oct 11, 2021
merlimat
approved these changes
Oct 11, 2021
hangc0276
added a commit
that referenced
this pull request
Oct 17, 2021
(cherry picked from commit e71d922)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we only set
bookkeeperUseV2WireProtocol=trueon Pulsar brokers to enforce brokers to use v2 protocol to avoid GC issues introduced by protobuf.However, we don’t set this setting on autorecovery, and the default value is false, Hence AutoRecovery will use v3 protocol.
We'd better set
useV2WireProtocol=truein autorecovery in the helm chartsModifications
Set
useV2WireProtocol=truein autorecovery.