[Issue 12271][Modernizer] Add Maven Modernizer plugin in pulsar-proxy module #12326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarlearning
force-pushed
the
modernizer-pulsar-proxy
branch
from
c7322cf
to
19853f6
Compare
|
@codelipenghui ready for review, need the approval to run the job. |
|
@MarvinCai PTAL |
|
/pulsarbot run-failure-checks |
MarvinCai
approved these changes
Oct 13, 2021
|
Thank you @eolivelli and @MarvinCai for reviewing 😄 |
jadireddi
reviewed
Oct 20, 2021
pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyStatsTest.java
Outdated
Show resolved
Hide resolved
jadireddi
reviewed
Oct 20, 2021
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyService.java
Outdated
Show resolved
Hide resolved
amarlearning
force-pushed
the
modernizer-pulsar-proxy
branch
from
19853f6
to
44624ff
Compare
merlimat
added
the
type/cleanup
merlimat
approved these changes
Oct 20, 2021
jadireddi
approved these changes
Oct 22, 2021
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Oct 25, 2021
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Oct 25, 2021
* up/master: (46 commits) [website][upgrade]feat: docs migration - version-2.7.2 Pulsar Schema (apache#12393) [docs] io-develop, fix broken link (apache#12414) docs(function): fix incorrect classname in python runtime sample (apache#12476) Remove redundant null check for getInternalListener (apache#12474) Fix the retry topic's `REAL_TOPIC` & `ORIGIN_MESSAGE_ID` property should not be modified once it has been written. (apache#12451) [cli] Fix output format of string by pulsar-admin command (apache#11878) fix the race of delete subscription and delete topic (apache#12240) fix influxdb yaml doc (apache#12460) [Modernizer] Add Maven Modernizer plugin in pulsar-proxy module (apache#12326) fix DefaultCryptoKeyReaderTest can not run on windows (apache#12475) apache#12429 only fixed the compactor skips data issue, but the normal reader/consumer (apache#12464) broker resource group test optimize fail msg (apache#12438) Stop OffsetStore when stopping the connector (apache#12457) fix a typo in UnAckedMessageTracker (apache#12467) docs(function): fix typo in pip install (apache#12468) Optimize the code: remove extra spaces (apache#12470) optimize SecurityUtility code flow (apache#12431) Update lombok to 1.18.22 (apache#12466) Update team.js to add David K. as a committer (apache#12440) Fix java demo error in reset cursor admin (apache#12454) ... # Conflicts: # site2/website-next/versioned_docs/version-2.7.2/schema-evolution-compatibility.md # site2/website-next/versioned_docs/version-2.7.2/schema-get-started.md # site2/website-next/versioned_docs/version-2.7.2/schema-manage.md # site2/website-next/versioned_docs/version-2.7.2/schema-understand.md # site2/website-next/versioned_sidebars/version-2.7.2-sidebars.json
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
lhotari
reviewed
Dec 7, 2021
| <executions> | ||
| <execution> | ||
| <id>modernizer</id> | ||
| <goals> |
There was a problem hiding this comment.
<phase>verify</phase> was missing here. Added in #13168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #12271
Motivation
Apply Maven Modernizer plugin to enforce we move away from legacy APIs.
Modifications
Add Maven Modernizer plugin in
pulsar-proxymodule and fix the violation.Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
Documentation
Need to update docs?