[C++] Delay ClientCredentialFlow::initialize to the first authenticate call #12372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
component/c++
doc-not-needed
BewareMyPower
requested review from
jiazhai,
aahmed-se,
merlimat,
rdhabalia,
sijie and
massakam
merlimat
reviewed
Oct 14, 2021
|
Now all tests passed, PTAL again @merlimat |
merlimat
approved these changes
Oct 15, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…e call (apache#12372) * Delay ClientCredentialFlow::initialize to the first time authenticate() is called * Make once_flag object a field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12325
Motivation
C++ client uses one logger per thread, but if the logger of a thread has been initialized, even if the logger factory was changed, this logger would still keep not changed.
When a
AuthOauth2object is created, it callsClientCredentialFlow::initialize, which callsLOG_DEBUGto try logging debug level logs. At this moment, the logger of the current thread is created and won't change after the custom logger factory is set inClientImpl's constructor. Then the custom logger won't work for that thread.Modifications
To avoid creating the logger in advance to
ClientImpl's constructor, this PR delaysClientCredentialFlow::initializeto the first timeClientCredentialFlow::authenticateis called. Usestd::call_onceto ensureinitializeis only called once.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.