Fixed: "Sqlcmd: Error: Microsoft ODBC Driver 17 for SQL Server : Login failed for user 'sa'.." in MS SQL integration test #12374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Oct 14, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…n failed for user 'sa'.." in MS SQL integration test (apache#12374) * set specific tag for image, use env var for the new image * moved to an older docker image * Updated wait strategy as outlined in microsoft/mssql-docker#625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sqlcmd: Error: Microsoft ODBC Driver 17 for SQL Server : Login failed for user 'sa'..in one of the runs of the MS SQL integration tests. Other runs succeeded, possibly due to the cached docker container image.Modifications
Looks like MSFT updated name of the env var that sets sa password, looks like the most possible explanation at the time (still testing locally).
Set specific tag for the image, added new env var.
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
NO
Documentation
Check the box below and label this PR (if you have committer privilege).