Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimization：remove unused isTxnMessage #12472

Merged
merged 1 commit into from
Oct 25, 2021
Merged

optimization：remove unused isTxnMessage #12472

merged 1 commit into from
Oct 25, 2021

Conversation

lordcheng10
Copy link
Contributor

Motivation

remove unused method： isTxnMessage

@eolivelli
Copy link
Contributor

@lordcheng10:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@lordcheng10 lordcheng10 changed the title remove unused isTxnMessage optimization：remove unused isTxnMessage Oct 24, 2021
@lordcheng10
Copy link
Contributor Author

@lordcheng10:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

No need to modify the document

@codelipenghui codelipenghui added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Oct 25, 2021
@codelipenghui codelipenghui added this to the 2.10.0 milestone Oct 25, 2021
@eolivelli eolivelli merged commit 464a9cd into apache:master Oct 25, 2021
zeo1995 pushed a commit to zeo1995/pulsar that referenced this pull request Oct 26, 2021
Merge branch 'up/master' into website/branch-2.7.2-chapter-4
fa9166a 
* up/master:
  [C++] Fixed connection read error logging (apache#12492)
  [Pulsar SQL] Pulsar SQL support query big entry data (apache#12448)
  [Java Client] Remove data race in MultiTopicsConsumerImpl to ensure correct message order (apache#12456)
  Allow to have different instances LocalMemoryMetadataStore that share the same state (apache#12390)
  Remove unused ConsumerImpl.isTxnMessage (apache#12472)
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
@lordcheng10 @eolivelli
Remove unused ConsumerImpl.isTxnMessage (apache#12472)
9d8ed84
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
@lordcheng10 @codelipenghui
Remove unused ConsumerImpl.isTxnMessage (#12472)
990be1c 
(cherry picked from commit 464a9cd)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
@gaoran10 gaoran10 added the type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@shoothzj shoothzj shoothzj approved these changes

@gaoran10 gaoran10 Awaiting requested review from gaoran10

@congbobo184 congbobo184 Awaiting requested review from congbobo184

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@lordcheng10 lordcheng10

Labels
cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.9.2 type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lordcheng10 @eolivelli @codelipenghui @shoothzj @gaoran10