Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update producer stats when producer close #12500

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

Demogorgon314
Copy link
Member

Fixes #12426

Motivation

See #12426

Modifications

When Producer cancelStatsTimeout, update stats

Verifying this change

This change added tests and can be verified as follows:

  • Added new test when producer close then get stats without arrive update interval

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc

This is enhancement, no need docs.

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 26, 2021
@Demogorgon314 Demogorgon314 marked this pull request as ready for review October 26, 2021 11:46
@merlimat merlimat merged commit 8486906 into apache:master Oct 26, 2021
@frankjkelly
Copy link
Contributor

Awesome - thanks!

zeo1995 pushed a commit to zeo1995/pulsar that referenced this pull request Oct 27, 2021
* up/master:
  fix delete authentication policies when delete topic. (apache#12215)
  [Broker] Fix messageDedup delete inactive producer name (apache#12493)
  Fixed getting children of parent nodes in LocalMemoryMetadataStore (apache#12491)
  Update Producer stats on producer close() (apache#12500)
  docs(cli):add restart command in pulsar-daemon (apache#12373)
  Add the pulsar java property memory allocator doc (apache#12481)
  [Doc]Update ci-documentbot.yml (apache#12480)
@merlimat merlimat added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Oct 30, 2021
@Demogorgon314 Demogorgon314 deleted the issues-12426 branch November 1, 2021 01:45
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Producer stats on producer flush() or close()
6 participants