Fix the batch message ack for WebSocket proxy. #12530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WebSocket proxy uses the consumer instance to process the message acknowledgement. But for the batch message acknowledgement, the batch message instance that deserialized from WebSocket proxy will with the same batch message acker, which will lead to the batch message can't been acked because of the consumer only send the ack request to the broker while the acker becomes empty. The fix is introduce a map to maintain an original which used for getting batch message acker. Added the test for covering the batch message ack.
codelipenghui
added
type/bug
merlimat
approved these changes
Oct 29, 2021
merlimat
added a commit
that referenced
this pull request
Oct 29, 2021
* Fix the batch message ack for WebSocket proxy. The WebSocket proxy uses the consumer instance to process the message acknowledgement. But for the batch message acknowledgement, the batch message instance that deserialized from WebSocket proxy will with the same batch message acker, which will lead to the batch message can't been acked because of the consumer only send the ack request to the broker while the acker becomes empty. The fix is introduce a map to maintain an original which used for getting batch message acker. Added the test for covering the batch message ack. * Simplified the logic a bit * Using time-bound cleanup for ack-timeout cases Co-authored-by: Matteo Merli <mmerli@apache.org>
merlimat
added a commit
that referenced
this pull request
Oct 29, 2021
* Fix the batch message ack for WebSocket proxy. The WebSocket proxy uses the consumer instance to process the message acknowledgement. But for the batch message acknowledgement, the batch message instance that deserialized from WebSocket proxy will with the same batch message acker, which will lead to the batch message can't been acked because of the consumer only send the ack request to the broker while the acker becomes empty. The fix is introduce a map to maintain an original which used for getting batch message acker. Added the test for covering the batch message ack. * Simplified the logic a bit * Using time-bound cleanup for ack-timeout cases Co-authored-by: Matteo Merli <mmerli@apache.org>
merlimat
added
cherry-picked/branch-2.9
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
* Fix the batch message ack for WebSocket proxy. The WebSocket proxy uses the consumer instance to process the message acknowledgement. But for the batch message acknowledgement, the batch message instance that deserialized from WebSocket proxy will with the same batch message acker, which will lead to the batch message can't been acked because of the consumer only send the ack request to the broker while the acker becomes empty. The fix is introduce a map to maintain an original which used for getting batch message acker. Added the test for covering the batch message ack. * Simplified the logic a bit * Using time-bound cleanup for ack-timeout cases Co-authored-by: Matteo Merli <mmerli@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebSocket proxy uses the consumer instance to process the message acknowledgment.
But for the batch message acknowledgment, the batch message instance that deserialized from WebSocket proxy will with the same batch message acker, which will lead to the batch message can't be acked because the consumer only sends the ack request to the broker while the acker becomes empty.
The fix is to introduce a map to maintain an original which is used for getting batch message acker.
Added the test for covering the batch message ack.