Websocket should pass the encryption context to the consumers #12539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/enhancement
merlimat
requested review from
rdhabalia,
hangc0276,
codelipenghui and
BewareMyPower
codelipenghui
approved these changes
Oct 30, 2021
|
For the doc side, @MarvinCai will provide explanations for orange-highlighted parts this weekend |
Anonymitaet
added
doc-complete
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
4 tasks
codelipenghui
pushed a commit
that referenced
this pull request
Dec 20, 2021
(cherry picked from commit d20efe5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix: #10021 #11197
Websocket service should provide the encryption context to its consumers, so that they can perform manual decryption of the message payloads.
An example of encryption context:
{ "messageId": "CAMQADAA", "payload": "hvXcJvHW7kOSrUn17P2q71RA5SdiXwZBqw==", "properties": {}, "publishTime": "2021-10-29T16:01:38.967-07:00", "redeliveryCount": 0, "encryptionContext": { "keys": { "client-rsa.pem": { "keyValue": "jEuwS+PeUzmCo7IfLNxqoj4h7txbLjCQjkwpaw5AWJfZ2xoIdMkOuWDkOsqgFmWwxiecakS6GOZHs94x3sxzKHQx9Oe1jpwBg2e7L4fd26pp+WmAiLm/ArZJo6JotTeFSvKO3u/yQtGTZojDDQxiqFOQ1ZbMdtMZA8DpSMuq+Zx7PqLo43UdW1+krjQfE5WD+y+qE3LJQfwyVDnXxoRtqWLpVsAROlN2LxaMbaftv5HckoejJoB4xpf/dPOUqhnRstwQHf6klKT5iNhjsY4usACt78uILT0pEPd14h8wEBidBz/vAlC/zVMEqiDVzgNS7dqEYS4iHbf7cnWVCn3Hxw==", "metadata": {} } }, "param": "Tfu1PxVm6S9D3+Hk", "compressionType": "NONE", "uncompressedMessageSize": 0, "batchSize": { "empty": false, "present": true } } }