Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transaction]Optimize the tests extends from TransactionTestBase #12560

Merged
merged 2 commits into from
Nov 1, 2021
Merged

[Transaction]Optimize the tests extends from TransactionTestBase #12560

merged 2 commits into from
Nov 1, 2021

Conversation

liangyepianzhou
Copy link
Contributor

Motivation

Extract common codes to reduce code redundancy.
Avoid the need to write repetitive code when a Class extend TransactionTestBase.

Modifications

Extract the code for creating Tc and the Topic for testing into the parent class.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • [x ] no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 1, 2021
@github-actions
Copy link

github-actions bot commented Nov 1, 2021

@liangyepianzhou:Thanks for providing doc info!

@liangyepianzhou liangyepianzhou changed the title [Transaction]Optimize Tests extends from TransactionTest [Transaction]Optimize the tests extends from TransactionTestBase Nov 1, 2021
@merlimat merlimat added this to the 2.10.0 milestone Nov 1, 2021
@merlimat merlimat merged commit cb703ca into apache:master Nov 1, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
(cherry picked from commit cb703ca)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.9.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants