Fix log typo in NamespaceService#checkHeartbeatNamespace #12582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eService#checkHeartbeatNamespaceV2
|
@Jason918:Thanks for providing doc info! |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Nov 4, 2021
codelipenghui
added
release/2.8.2
cherry-picked/branch-2.8
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…eService#checkHeartbeatNamespaceV2 (apache#12582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The log of
org.apache.pulsar.broker.namespace.NamespaceService#checkHeartbeatNamespaceandorg.apache.pulsar.broker.namespace.NamespaceService#checkHeartbeatNamespaceV2have the same log line but not matching the method name, which is confusing.
Modifications
Changed the log content to match the method name.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-docJust fix typo
doc(If this PR contains doc changes)