Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid firstSentAt in log message when timeout first time #12588

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Fix invalid firstSentAt in log message when timeout first time #12588

merged 1 commit into from
Nov 4, 2021

Conversation

wuzhanpeng
Copy link
Contributor

Simple fix to firstSentAt when it first timed out.

An example of abnormal output:

org.apache.pulsar.client.api.PulsarClientException$TimeoutException: The producer XXX can not send message to the topic YYY within given timeout : createdAt 30004180480 ns ago, firstSentAt 32225437594084969 ns ago, lastSentAt 30004087361 ns ago, retryCount 1

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

@wuzhanpeng:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@hangc0276 hangc0276 added this to the 2.10.0 milestone Nov 2, 2021
@wuzhanpeng
Copy link
Contributor Author

@wuzhanpeng:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

No need to update documentation. Thanks~

@Anonymitaet Anonymitaet added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 3, 2021
@codelipenghui codelipenghui merged commit 2ca96e4 into apache:master Nov 4, 2021
codelipenghui pushed a commit that referenced this pull request Nov 18, 2021
@wuzhanpeng @codelipenghui
Fix invalid firstSentAt value (#12588)
eccacaf 
(cherry picked from commit 2ca96e4)
@codelipenghui codelipenghui added release/2.8.2 cherry-picked/branch-2.8 Archived: 2.8 is end of life and removed release/2.8.3 labels Nov 18, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
@wuzhanpeng @eolivelli
Fix invalid firstSentAt value (apache#12588)
b9ebd3d
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
@wuzhanpeng @codelipenghui
Fix invalid firstSentAt value (#12588)
7e97e6c 
(cherry picked from commit 2ca96e4)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangc0276 hangc0276 hangc0276 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@eolivelli eolivelli Awaiting requested review from eolivelli

@315157973 315157973 Awaiting requested review from 315157973

Assignees

@wuzhanpeng wuzhanpeng

Labels
area/client cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.2
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wuzhanpeng @hangc0276 @codelipenghui @eolivelli @Anonymitaet