-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix call sync method in an async callback when enabling geo replicator. #12590
Merged
codelipenghui
merged 10 commits into
apache:master
from
codelipenghui:penghui/fix-replicator-async
Nov 6, 2021
Merged
Fix call sync method in an async callback when enabling geo replicator. #12590
codelipenghui
merged 10 commits into
apache:master
from
codelipenghui:penghui/fix-replicator-async
Nov 6, 2021
Commits on Nov 2, 2021
-
Fix call sync method in an async callback when enabling geo replicator.
After enabled geo-replication, we are not able to produce messages to a partitioned non-persistent topic. Reproduce step: 1. Start a geo-replication instance with 2 clusters, I have 3 brokers for each cluster 2. Create a non-persistent partitioned topic such as 10 partitions 3. Use pulsar-perf to publish messages to the partitioned topic 4. Verify if the message produce throughput is 0, such as `bin/pulsar-perf produce -s 2048 -r 100 -bm 1 non-persistent://public/default/test` The root cause is there are 2 places calling a sync method in the async method callback. So the fix is: 1. Async the `validatePartitionedTopicAsync` method 2. Avoid call get cluster sync method when getting the replication client Integration tests added.
Configuration menu - View commit details
-
Copy full SHA for cd76506 - Browse repository at this point
Copy the full SHA cd76506View commit details
Commits on Nov 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for aa6130d - Browse repository at this point
Copy the full SHA aa6130dView commit details
Commits on Nov 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for abd5360 - Browse repository at this point
Copy the full SHA abd5360View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53ba4b4 - Browse repository at this point
Copy the full SHA 53ba4b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9b13e6 - Browse repository at this point
Copy the full SHA b9b13e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7836fd3 - Browse repository at this point
Copy the full SHA 7836fd3View commit details -
Fix getting cluster data synchronously in an asynchronously method wh…
…en creating partitioned-topic, this will cause dead thread problem.
Configuration menu - View commit details
-
Copy full SHA for 803ca3e - Browse repository at this point
Copy the full SHA 803ca3eView commit details
Commits on Nov 5, 2021
-
fix non-persistent-topc create logic
congbo committedNov 5, 2021 Configuration menu - View commit details
-
Copy full SHA for b8f5b26 - Browse repository at this point
Copy the full SHA b8f5b26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43d0e96 - Browse repository at this point
Copy the full SHA 43d0e96View commit details
Commits on Nov 6, 2021
-
Fix code style and change some annotation
congbo committedNov 6, 2021 Configuration menu - View commit details
-
Copy full SHA for baaf6b0 - Browse repository at this point
Copy the full SHA baaf6b0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.