Reduced severity of log "refreshing key manager" in KeyManagerProxy #12594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/enhancement
merlimat
requested review from
rdhabalia,
hangc0276,
codelipenghui and
BewareMyPower
hangc0276
approved these changes
Nov 3, 2021
codelipenghui
added
release/2.8.2
cherry-picked/branch-2.8
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Each time the
pulsar-admintool is launched with TLS certificates configured, it is printing an info log "refreshing key manager for my-cert.pem` at least twice.This is noisy in that we shouldn't have any extra output in
pulsar-adminin order to make it possible to use it from scripts. Also, it's a bit confusing since it's technically the first time we're reading those certs and not a refresh.