Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional error handling in auto partition update task MultiTopicsConsumerImpl #12620

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

jerrypeng
Copy link
Contributor

Motivation

Currently if any errors happen in the partitionsAutoUpdateTimerTask, another task will not be scheduled. Lets add some error handling to make sure that even if the current run has errors, we will retry in the future.

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?
no

@jerrypeng jerrypeng self-assigned this Nov 4, 2021
@jerrypeng jerrypeng added this to the 2.9.0 milestone Nov 4, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

@jerrypeng:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

@jerrypeng:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@merlimat merlimat added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 4, 2021
@merlimat merlimat merged commit 11cfbe4 into apache:master Nov 4, 2021
jerrypeng added a commit to jerrypeng/incubator-pulsar that referenced this pull request Nov 4, 2021
…csConsumerImpl (apache#12620)

Co-authored-by: Jerry Peng <jerryp@splunk.com>
eolivelli pushed a commit that referenced this pull request Nov 9, 2021
…csConsumerImpl (#12620)

Co-authored-by: Jerry Peng <jerryp@splunk.com>
(cherry picked from commit 11cfbe4)
codelipenghui pushed a commit that referenced this pull request Nov 18, 2021
…csConsumerImpl (#12620)

Co-authored-by: Jerry Peng <jerryp@splunk.com>
(cherry picked from commit 11cfbe4)
@codelipenghui codelipenghui added release/2.8.2 cherry-picked/branch-2.8 Archived: 2.8 is end of life and removed release/2.8.3 labels Nov 18, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
…csConsumerImpl (apache#12620)

Co-authored-by: Jerry Peng <jerryp@splunk.com>
aloyszhang pushed a commit to aloyszhang/pulsar that referenced this pull request Aug 5, 2022
Squash merge branch 'fix_add_partiton_error' into '2.8.1'
### Motivation
修复pulsar client,扩分区不感知问题
chery pick from apache#12620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants