[Config] Add readWorkerThreadsThrottlingEnabled to conf/bookkeeper.conf #12666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- apache/bookkeeper#2646 added "Auto-throttle read operations" which is enabled by default
lhotari
added
component/bookkeeper
doc-not-needed
|
@dlg99 Please review |
|
@merlimat can you please comment on the 'open question' ? This is the line for whom is interested in checking out the source code in BK |
codelipenghui
approved these changes
Nov 9, 2021
merlimat
approved these changes
Nov 10, 2021
The The purpose is indeed to apply back-pressure and avoid unlimited memory usage in the Bookie. |
codelipenghui
pushed a commit
that referenced
this pull request
Nov 18, 2021
…nf (#12666) - apache/bookkeeper#2646 added "Auto-throttle read operations" which is enabled by default (cherry picked from commit fc6d6da)
codelipenghui
added
cherry-picked/branch-2.8
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…nf (apache#12666) - apache/bookkeeper#2646 added "Auto-throttle read operations" which is enabled by default
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2021
…nf (#12666) - apache/bookkeeper#2646 added "Auto-throttle read operations" which is enabled by default (cherry picked from commit fc6d6da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
readWorkerThreadsThrottlingEnabled=truetoconf/bookkeeper.confsince that is the default value in BookKeeper that gets used unless the setting is explicitly set tofalse.Open questions
readWorkerThreadsThrottlingEnabled=truea safe default?.await()and Auto-throttle read operations bookkeeper#2646 uses thatChannelFuture.await()to block.