[pulsar-client] Fix pending queue-size stats for batch messages #12704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdhabalia:Thanks for your contribution. For this PR, do we need to update docs? |
1 similar comment
|
@rdhabalia:Thanks for your contribution. For this PR, do we need to update docs? |
rdhabalia
force-pushed
the
pending_stat_batch
branch
from
389e722
to
8ba55d8
Compare
codelipenghui
approved these changes
Nov 10, 2021
|
@rdhabalia seems that this is a bug fix and does not affect the user guide, so no need to update docs here? |
|
@Anonymitaet it won't require doc change. |
Anonymitaet
added
doc-not-needed
|
@rdhabalia thanks. when submitting a PR, can you help provide a doc label (tick the box)? Thanks |
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Dec 20, 2021
(cherry picked from commit 9a3e7ec)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, pulsar-client prints stats with incorrect pending queue size for the batch messages. if the user configures batch-message size 100 (or batch delay is 10ms) and publishes 1000 messages then the producer prints stats with < 10 pending messages instead 1000 messages which is published by user. It confuses the user because the user sees a different counter than actual published messages. it creates confusion when the user gets ProducerQueueFull Error and stats prints queue size is 10 and allowed pending-messages are 1000.
Modification
Show correct pending messages for batch messages.