Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant placeholders #12717

Merged
merged 1 commit into from Nov 15, 2021
Merged

remove redundant placeholders #12717

merged 1 commit into from Nov 15, 2021

Conversation

gaozhangmin
Copy link
Contributor

@gaozhangmin gaozhangmin commented Nov 10, 2021 •
edited

Motivation

Num of placeholders does not match number of arguments in logging

Modifications

remove unnecessary placeholders

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API: (yes / no) no
  • The schema: (yes / no / don't know) no
  • The default values of configurations: (yes / no) no
  • The wire protocol: (yes / no) no
  • The rest endpoints: (yes / no) no
  • The admin cli options: (yes / no) no
  • Anything that affects deployment: (yes / no / don't know) no

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc

@github-actions
Copy link

@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions
Copy link

@gaozhangmin:Thanks for providing doc info!

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 10, 2021
@codelipenghui codelipenghui added this to the 2.10.0 milestone Nov 10, 2021
@gaozhangmin
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 4fac93c into apache:master Nov 15, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
@gaozhangmin @eolivelli
remove redundant placeholders (apache#12717)
ce902d0
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
@gaozhangmin
remove redundant placeholders (apache#12717)
485a6ac
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
@gaozhangmin @codelipenghui
remove redundant placeholders (#12717)
b6ae157 
(cherry picked from commit 4fac93c)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
@gaoran10 gaoran10 added the type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@shoothzj shoothzj shoothzj approved these changes

@yuruguo yuruguo yuruguo approved these changes

Assignees

@gaozhangmin gaozhangmin

Labels
cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.9.2 type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gaozhangmin @codelipenghui @shoothzj @yuruguo @eolivelli @gaoran10