Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Even if always compatible is set, Consumers cannot be created #12721

Merged
merged 3 commits into from Nov 12, 2021
Merged

Even if always compatible is set, Consumers cannot be created #12721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
124626f
Even if always compatible is set, Consumers cannot be created
315157973 Nov 10, 2021
ea97643
move into checkConsumerCompatibility()
315157973 Nov 10, 2021
7a0f821
use == instead of equals
315157973 Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...oker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java
View file
Open in desktop
Expand Up @@ -270,6 +270,9 @@ public CompletableFuture<Long> findSchemaVersion(String schemaId, SchemaData sch
@Override
public CompletableFuture<Void> checkConsumerCompatibility(String schemaId, SchemaData schemaData,
SchemaCompatibilityStrategy strategy) {
if (SchemaCompatibilityStrategy.ALWAYS_COMPATIBLE == strategy) {
return CompletableFuture.completedFuture(null);
}
return getSchema(schemaId).thenCompose(existingSchema -> {
if (existingSchema != null && !existingSchema.schema.isDeleted()) {
if (strategy == SchemaCompatibilityStrategy.BACKWARD
Expand Down
22 changes: 22 additions & 0 deletions ...er/src/test/java/org/apache/pulsar/schema/compatibility/SchemaCompatibilityCheckTest.java
View file
Open in desktop
Expand Up @@ -395,6 +395,28 @@ public void testProducerSendWithOldSchemaAndConsumerCanRead(SchemaCompatibilityS

}

@Test
public void testAutoProduceSchemaAlwaysCompatible() throws Exception {
final String tenant = PUBLIC_TENANT;
final String topic = "topic" + randomName(16);

String namespace = "test-namespace-" + randomName(16);
String topicName = TopicName.get(
TopicDomain.persistent.value(), tenant, namespace, topic).toString();
NamespaceName namespaceName = NamespaceName.get(tenant, namespace);
admin.namespaces().createNamespace(tenant + "/" + namespace, Sets.newHashSet(CLUSTER_NAME));

// set ALWAYS_COMPATIBLE
admin.namespaces().setSchemaCompatibilityStrategy(namespaceName.toString(), SchemaCompatibilityStrategy.ALWAYS_COMPATIBLE);

Producer producer = pulsarClient.newProducer(Schema.AUTO_PRODUCE_BYTES()).topic(topicName).create();
// should not fail
Consumer<String> consumer = pulsarClient.newConsumer(Schema.STRING).subscriptionName("my-sub").topic(topicName).subscribe();

producer.close();
consumer.close();
}

@Test(dataProvider = "CanReadLastSchemaCompatibilityStrategy")
public void testConsumerWithNotCompatibilitySchema(SchemaCompatibilityStrategy schemaCompatibilityStrategy) throws Exception {
final String tenant = PUBLIC_TENANT;
Expand Down