[Pulsar SQL] Handle message null schema version in PulsarRecordCursor #12809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
requested review from
merlimat,
codelipenghui,
congbobo184,
hangc0276,
jerrypeng and
zymap
codelipenghui
approved these changes
Nov 15, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Nov 18, 2021
…#12809) ### Motivation Currently, if the schema version of the message is null, the Pulsar SQL will encounter an NPE problem. ### Modifications Adjust logic for null schema version in `PulsarRecordCursor`. 1. If the schema type of pulsarSplit is NONE or BYTES, use the BYTES schema. 2. If the schema type of pulsarSplit is BYTEBUFFER, use the BYTEBUFFER schema. 3. If the schema version of the message is null, use the latest schema of the topic. 4. If the schema version of the message is not null, get the specific version schema by PulsarAdmin. 5. If the final schema is null throw a runtime exception. (cherry picked from commit e5619cf)
codelipenghui
added
cherry-picked/branch-2.8
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…apache#12809) ### Motivation Currently, if the schema version of the message is null, the Pulsar SQL will encounter an NPE problem. ### Modifications Adjust logic for null schema version in `PulsarRecordCursor`. 1. If the schema type of pulsarSplit is NONE or BYTES, use the BYTES schema. 2. If the schema type of pulsarSplit is BYTEBUFFER, use the BYTEBUFFER schema. 3. If the schema version of the message is null, use the latest schema of the topic. 4. If the schema version of the message is not null, get the specific version schema by PulsarAdmin. 5. If the final schema is null throw a runtime exception.
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…apache#12809) ### Motivation Currently, if the schema version of the message is null, the Pulsar SQL will encounter an NPE problem. ### Modifications Adjust logic for null schema version in `PulsarRecordCursor`. 1. If the schema type of pulsarSplit is NONE or BYTES, use the BYTES schema. 2. If the schema type of pulsarSplit is BYTEBUFFER, use the BYTEBUFFER schema. 3. If the schema version of the message is null, use the latest schema of the topic. 4. If the schema version of the message is not null, get the specific version schema by PulsarAdmin. 5. If the final schema is null throw a runtime exception.
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2021
…#12809) ### Motivation Currently, if the schema version of the message is null, the Pulsar SQL will encounter an NPE problem. ### Modifications Adjust logic for null schema version in `PulsarRecordCursor`. 1. If the schema type of pulsarSplit is NONE or BYTES, use the BYTES schema. 2. If the schema type of pulsarSplit is BYTEBUFFER, use the BYTEBUFFER schema. 3. If the schema version of the message is null, use the latest schema of the topic. 4. If the schema version of the message is not null, get the specific version schema by PulsarAdmin. 5. If the final schema is null throw a runtime exception. (cherry picked from commit e5619cf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, if the schema version of the message is null, the Pulsar SQL will encounter an NPE problem.
Modifications
Adjust logic for null schema version in
PulsarRecordCursor.Verifying this change
Add a new test for the method
getSchemaInfoto verify get the correct schema info.Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)