-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Broker] Synchronize updates to the inactiveProducers map in MessageD… #12820
[Broker] Synchronize updates to the inactiveProducers map in MessageD… #12820
Conversation
@merlimat and @congbobo184 - PTAL. Based on #12493 (comment), it looks like we prefer synchronization on the class as opposed to using a concurrent hash map. Let me know if my assumption here is correct, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@merlimat I can include this patch in 2.9.0. |
depends on #12493 |
…eduplication (apache#12820) (cherry picked from commit 9994614) (cherry picked from commit e12bcc2)
…eduplication
Motivation
In #12493, we introduced potentially concurrent updates to the
inactiveProducers
map without any synchronization.Modifications
inactiveProducers
map using proper synchronization.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
No breaking changes.
Documentation
no-need-doc