[pulsar-admin] Add get-replicated-subscription-status command for topic #12891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuruguo:Thanks for your contribution. For this PR, do we need to update docs? |
codelipenghui
requested changes
Nov 19, 2021
| // Permission to consume this topic is required | ||
| validateTopicOperation(topicName, TopicOperation.GET_REPLICATED_SUBSCRIPTION_STATUS); | ||
|
|
||
| Topic topic = getTopicReference(topicName); |
There was a problem hiding this comment.
Need to check the ownership first, otherwise the topic might be owned by another broker.
There was a problem hiding this comment.
And the partitioned topic should be handled.
There was a problem hiding this comment.
Thanks for your sugesstion and I have add related logic, PTAL again :)
Anonymitaet
added
doc
codelipenghui
approved these changes
Nov 22, 2021
hangc0276
approved these changes
Nov 30, 2021
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Dec 1, 2021
* up/master: (75 commits) [website][upgrade]feat: website upgrade / docs migration - 2.5.1 Get Started/Concepts and Architecture/Pulsar Schema (apache#13030) Fix environment variable assignment in startup scripts (apache#13025) update 2.8.x (apache#13029) [Doc] add tips for Pulsar tools (apache#13044) Suggest to use tlsPort instead of deprecated TlsEnable (apache#13039) Integration tests for function-worker rebalance and drain operations. (apache#13058) fix(functions): missing runtime set in GoInstanceConfig (apache#13031) [pulsar-admin] Add get-replicated-subscription-status command for topic (apache#12891) [Broker] Consider topics in pulsar/system namespace as system topics (apache#13050) Fix typo: correct sizeUint to sizeUnit (apache#13040) fix-12894 (apache#12896) Don't attempt to delete pending ack store unless transactions are enabled (apache#13041) [Perf] Evaluate the current protocol version once (apache#13045) Fix Issue apache#12885, Unordered consuming case in Key_Shared subscription (apache#12890) [broker]Optimize topicMaxMessageSize with topic local cache. (apache#12830) [PIP-105] Part-2 Support pluggable entry filter in Dispatcher (apache#12970) [website] Modify admin-api-topic.md document (apache#12996) add missed import (apache#13037) [metadata] Add RocksdbMetadataStore (apache#12776) [C] Add pulsar_client_subscribe_multi_topics and pulsar_client_subscribe_pattern (apache#12965) ... # Conflicts: # site2/website-next/docusaurus.config.js # site2/website-next/versioned_sidebars/version-2.6.1-sidebars.json # site2/website-next/versions.json
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…ic (apache#12891) ### Motivation CLI `bin/pulsar-admin topics` supports `set-replicated-subscription-status` but lacks corresponding `get-replicated-subscription-status` command, the purpose of this PR is to add this command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CLI
bin/pulsar-admin topicssupportsset-replicated-subscription-statusbut lacks correspondingget-replicated-subscription-statuscommand, the purpose of this PR is to add this command.Documentation
Automatically generate doc through code
doc