[metadata] Optimize put and get methods in AbstractMetadataStore #12916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Nov 22, 2021
hangc0276
approved these changes
Nov 22, 2021
merlimat
approved these changes
Nov 22, 2021
merlimat
added
the
type/enhancement
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Nov 23, 2021
* up/master: [Doc] add explanations for REST (apache#12918) [Doc] add explanations for permissions (apache#12920) Apply executable file permissions to py scripts. (apache#12852) Fix log level config for pulsar-admin, pulsar-client and pulsar-perf (apache#12915) Abstract some common methods to AbstractMetadataStore (apache#12916) Build website using https://pulsar.apache.org (apache#12901)
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Nov 23, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For the convenience to implement other metadata store, I am proposing two small optimizations to AbstractMetadataStore.
putis the same inLocalMemoryMetadataStoreandZKMetadataStore, can be moved to AbstractMetadataStore.storeGetin AbstractMetadataStore, so that all subclass only need to implement "storeXXX" version methods. And we can add common code inAbstractMetadataStore#getlike the path parameter check.Modifications
See above.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docCode optimize. No user behavior changed.