Fix zk-node leak of admin path #12972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
wolfstudy
requested review from
merlimat,
hangc0276,
codelipenghui and
zymap
Jason918
approved these changes
Nov 27, 2021
|
/pulsarbot run-failure-checks |
congbobo184
approved these changes
Nov 29, 2021
zymap
approved these changes
Nov 29, 2021
|
/pulsarbot run-failure-checks |
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
Signed-off-by: xiaolongran <xiaolongran@tencent.com> Fixes apache#12968 ### Motivation When we run follow command: ``` bin/pulsar-admin tenants delete test2 ``` the zk-node of `/admin/partitioned-topics` and `/admin/local-policies` wil not remove, casued by zk-node leak. ### Modifications - clear tenant zk-node of `/admin/partitioned-topics/` - clear tenant zk-node of `/admin/local-policies/` - add test case
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
Signed-off-by: xiaolongran <xiaolongran@tencent.com> Fixes apache#12968 ### Motivation When we run follow command: ``` bin/pulsar-admin tenants delete test2 ``` the zk-node of `/admin/partitioned-topics` and `/admin/local-policies` wil not remove, casued by zk-node leak. ### Modifications - clear tenant zk-node of `/admin/partitioned-topics/` - clear tenant zk-node of `/admin/local-policies/` - add test case
codelipenghui
added
release/2.9.4
release/2.8.5
type/bug
congbobo184
pushed a commit
that referenced
this pull request
Nov 30, 2022
Signed-off-by: xiaolongran <xiaolongran@tencent.com> Fixes #12968 When we run follow command: ``` bin/pulsar-admin tenants delete test2 ``` the zk-node of `/admin/partitioned-topics` and `/admin/local-policies` wil not remove, casued by zk-node leak. - clear tenant zk-node of `/admin/partitioned-topics/` - clear tenant zk-node of `/admin/local-policies/` - add test case (cherry picked from commit 86fe7d2)
congbobo184
pushed a commit
to congbobo184/pulsar
that referenced
this pull request
Dec 1, 2022
Signed-off-by: xiaolongran <xiaolongran@tencent.com> Fixes apache#12968 When we run follow command: ``` bin/pulsar-admin tenants delete test2 ``` the zk-node of `/admin/partitioned-topics` and `/admin/local-policies` wil not remove, casued by zk-node leak. - clear tenant zk-node of `/admin/partitioned-topics/` - clear tenant zk-node of `/admin/local-policies/` - add test case (cherry picked from commit 86fe7d2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolongran xiaolongran@tencent.com
Fixes #12968
Motivation
When we run follow command:
the zk-node of
/admin/partitioned-topicsand/admin/local-policieswil not remove, casued by zk-node leak.Modifications
/admin/partitioned-topics//admin/local-policies/