Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): support autorecovery service in pulsar cli #12985

Merged
merged 1 commit into from
Nov 27, 2021
Merged

feat(cli): support autorecovery service in pulsar cli #12985

merged 1 commit into from
Nov 27, 2021

Conversation

ericsyh
Copy link
Contributor

@ericsyh ericsyh commented Nov 26, 2021

Signed-off-by: Eric Shen ericshenyuhao@outlook.com

Motivation

Autorecovery service will be shutdown if the zk session expired and then will lead the bk service shutdown together. So, in the production environment, it is recommand to deploy autorecovery service seperately but currently pulsar doesn't support it.

Modifications

  • Added the autorecovery service in pulsar cli
  • Added the autorecovery service in pulsar-daemon cli

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 26, 2021
@ericsyh
Copy link
Contributor Author

ericsyh commented Nov 26, 2021

@hangc0276 @codelipenghui PTAL

@codelipenghui codelipenghui added this to the 2.10.0 milestone Nov 26, 2021
@codelipenghui codelipenghui added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages release/2.8.3 release/2.9.1 labels Nov 26, 2021
Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! thanks @ericsyh

@hangc0276 hangc0276 merged commit f192209 into apache:master Nov 27, 2021
@ericsyh ericsyh deleted the cli-support-autorecovery branch November 27, 2021 06:03
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
### Motivation
Autorecovery service will be shutdown if the zk session expired and then will lead the bk service shutdown together. So, in the production environment, it is recommand to deploy autorecovery service seperately but currently pulsar doesn't support it.

### Modifications
Added the autorecovery service in pulsar cli
Added the autorecovery service in pulsar-daemon cli
@Anonymitaet Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-not-needed Your PR changes do not impact docs labels Nov 30, 2021
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
### Motivation
Autorecovery service will be shutdown if the zk session expired and then will lead the bk service shutdown together. So, in the production environment, it is recommand to deploy autorecovery service seperately but currently pulsar doesn't support it.

### Modifications
Added the autorecovery service in pulsar cli
Added the autorecovery service in pulsar-daemon cli
codelipenghui pushed a commit that referenced this pull request Dec 21, 2021
### Motivation
Autorecovery service will be shutdown if the zk session expired and then will lead the bk service shutdown together. So, in the production environment, it is recommand to deploy autorecovery service seperately but currently pulsar doesn't support it.

### Modifications
Added the autorecovery service in pulsar cli
Added the autorecovery service in pulsar-daemon cli

(cherry picked from commit f192209)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 21, 2021
zymap pushed a commit that referenced this pull request Dec 23, 2021
### Motivation
Autorecovery service will be shutdown if the zk session expired and then will lead the bk service shutdown together. So, in the production environment, it is recommand to deploy autorecovery service seperately but currently pulsar doesn't support it.

### Modifications
Added the autorecovery service in pulsar cli
Added the autorecovery service in pulsar-daemon cli

(cherry picked from commit f192209)
@zymap zymap added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-complete Your PR changes impact docs and the related docs have been already added. release/2.8.3 release/2.9.2 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants