Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] [broker] support broker isolation for uniform load shedder strategy #13080

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rdhabalia
Copy link
Contributor

Motivation

We added Uniform load balancer strategy in #12902 which considers all the brokers and distributes the load uniformly across all available brokers. However, it doesn't consider namespace isolation policies where we want to uniformly distribute load across brokers which are part of same isolation group. This PR supports namespace isolation and distribute load across that subset of brokers based on their isolation group.

Modification

UniformLoadShedder prepares group of brokers which are part of isolation policy and try to find out bundle-candidate such a way it uniformly distributes load across that prepared group.

Result

UniformLoadShedder considers namespace isolation policy while distributing the load.

@rdhabalia rdhabalia added this to the 2.10.0 milestone Dec 2, 2021
@rdhabalia rdhabalia self-assigned this Dec 2, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

@rdhabalia:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

@rdhabalia:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@rdhabalia rdhabalia force-pushed the uniform_shedder_isolation branch 2 times, most recently from 53af3f1 to b4473e2 Compare December 2, 2021 03:43
@Anonymitaet
Copy link
Member

@rdhabalia for the doc side, will you add explanations here?

@rdhabalia
Copy link
Contributor Author

@Anonymitaet it's just an internal handling and it will not require any additional documentation

@lordcheng10
Copy link
Contributor

When the traffic to be unloaded is too small, there is no need to unload at this time to avoid unnecessary unload:#13140

@rdhabalia
Copy link
Contributor Author

ping.

@codelipenghui codelipenghui modified the milestones: 2.10.0, 2.11.0 Jan 25, 2022
@rdhabalia
Copy link
Contributor Author

@codelipenghui this PR was created 2 months back and ready to merge then why did you move to 2.11 release?

@rdhabalia
Copy link
Contributor Author

this is not acceptable

@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@Anonymitaet Anonymitaet added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jun 9, 2022
@codelipenghui codelipenghui modified the milestones: 2.11.0, 2.12.0 Jul 26, 2022
@poorbarcode poorbarcode changed the title [pulsar-broker] support broker isolation for uniform load shedder strategy [feat] [broker] support broker isolation for uniform load shedder strategy Apr 10, 2023
@poorbarcode poorbarcode modified the milestones: 3.0.0, 3.1.0 Apr 10, 2023
@poorbarcode
Copy link
Contributor

Since we will start the RC version of 3.0.0 on 2023-04-11, I will change the label/milestone of PR who have not been merged.

  • The PR of type feature is deferred to 3.1.0
  • The PR of type fix is deferred to 3.0.1

So drag this PR to 3.1.0

@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Apr 10, 2023
@github-actions
Copy link

@rdhabalia Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@Technoboy- Technoboy- modified the milestones: 3.1.0, 3.2.0 Jul 31, 2023
@Technoboy- Technoboy- modified the milestones: 3.2.0, 3.3.0 Dec 22, 2023
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants