[Transaction] Add a check for uninitialized PendingAck #13088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shoud not generate the statistics of a uninitialized PendingAck,and we should check if it is initialized when we get it by `getStoreManageLedger()`. ### Modifications Shoud not generate the statistics of a uninitialized PendingAck Add check if it is initialized when we get it by `getStoreManageLedger()`.
|
Please update the title to something meaningful |
liangyepianzhou
changed the title
|
/pulsarbot run-failure-checks |
congbobo184
requested review from
congbobo184,
codelipenghui,
eolivelli and
gaoran10
congbobo184
requested changes
Dec 3, 2021
...src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
Outdated
Show resolved
Hide resolved
...ar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TransactionAggregator.java
Show resolved
Hide resolved
congbobo184
approved these changes
Dec 3, 2021
codelipenghui
approved these changes
Dec 6, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
### Motivation We shoud not generate the statistics of a uninitialized PendingAck,and we should check if it is initialized when we get it by `getStoreManageLedger()`. ### Modifications Shoud not generate the statistics of a uninitialized PendingAck Add check if it is initialized when we get it by `getStoreManageLedger()`.
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2021
### Motivation We shoud not generate the statistics of a uninitialized PendingAck,and we should check if it is initialized when we get it by `getStoreManageLedger()`. ### Modifications Shoud not generate the statistics of a uninitialized PendingAck Add check if it is initialized when we get it by `getStoreManageLedger()`. (cherry picked from commit 591b4e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should not generate the statistics of a uninitialized PendingAck,and we should check if it is initialized when we get it by
getStoreManageLedger().Modifications
Do not generate the statistics of a uninitialized PendingAck.
Add check if it is initialized when we get it by
getStoreManageLedger().Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)