[C++]Fix libcurl miss auth header when broker return 307 #13112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@billowqiu:Thanks for your contribution. For this PR, do we need to update docs? |
wolfstudy
requested review from
BewareMyPower,
massakam,
ivankelly,
wolfstudy,
315157973 and
codelipenghui
|
cc @BewareMyPower PTAL thanks |
|
Please use clang-format-5.0 to reformat your code first. |
|
@billowqiu:Thanks for providing doc info! |
github-actions
bot
added
doc-not-needed
Co-authored-by: Yunze Xu <xyzinfernity@163.com>
BewareMyPower
approved these changes
Dec 3, 2021
315157973
reviewed
Dec 5, 2021
315157973
approved these changes
Dec 9, 2021
2 tasks
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 10, 2021
* [C++]Fix libcurl miss auth header when broker return 307 Motivation when broker restart, it will return 307 to client for lookup request. but libcurl miss auth heander when follow new url which will issue the follow lookup req fail with 401. Modifications don't use libcurl CURLOPT_FOLLOWLOCATION to follow new url, instead use retry request with auth header.
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
* [C++]Fix libcurl miss auth header when broker return 307 Motivation when broker restart, it will return 307 to client for lookup request. but libcurl miss auth heander when follow new url which will issue the follow lookup req fail with 401. Modifications don't use libcurl CURLOPT_FOLLOWLOCATION to follow new url, instead use retry request with auth header.
codelipenghui
pushed a commit
that referenced
this pull request
Dec 22, 2021
* [C++]Fix libcurl miss auth header when broker return 307 Motivation when broker restart, it will return 307 to client for lookup request. but libcurl miss auth heander when follow new url which will issue the follow lookup req fail with 401. Modifications don't use libcurl CURLOPT_FOLLOWLOCATION to follow new url, instead use retry request with auth header. (cherry picked from commit dd8b473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12888
Motivation
when broker restart, it will return 307 to client for lookup request.
but libcurl miss auth heander when follow new url which will issue the follow lookup req fail with 401.
Modifications
don't use libcurl CURLOPT_FOLLOWLOCATION to follow new url, instead use retry request with auth header.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc