Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Java Client ] fix parseProtobufSchema method will be called two times. #13163

Merged
merged 1 commit into from
Dec 10, 2021
Merged

[ Java Client ] fix parseProtobufSchema method will be called two times. #13163

merged 1 commit into from
Dec 10, 2021

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Dec 7, 2021 •
edited by Anonymitaet
Loading

  • fix MultiVersionGenericProtobufNativeReader.parseProtobufSchema method will be called two times.

  • no-need-doc

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

@mattisonchao:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@mattisonchao
Copy link
Member Author

/pulsarbot rerun-failure-checks

1 similar comment
@mattisonchao
Copy link
Member Author

/pulsarbot rerun-failure-checks

@michaeljmarshall michaeljmarshall added this to the 2.10.0 milestone Dec 7, 2021
@Anonymitaet
Copy link
Member

Hi @mattisonchao please do not delete the backticks for no-need-doc (the correct format is no-need-doc), otherwise, Bot can not recognize it and does not give the correct label to PR.
image

I've corrected your description on that.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

@mattisonchao:Thanks for providing doc info!

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 8, 2021
@mattisonchao
Copy link
Member Author

Hi @mattisonchao please do not delete the backticks for no-need-doc (the correct format is no-need-doc), otherwise, Bot can not recognize it and does not give the correct label to PR. image

I've corrected your description on that.

Okay, I will follow the standard. thanks to you.

@codelipenghui codelipenghui changed the title [ Java Client ] fix method will be called two times. [ Java Client ] fix parseProtobufSchema method will be called two times. Dec 10, 2021
@codelipenghui codelipenghui merged commit 00127bc into apache:master Dec 10, 2021
@mattisonchao mattisonchao deleted the fixed_genericprotobuf_native_reader branch December 10, 2021 14:01
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
@mattisonchao
[ Java Client ] fix parseProtobufSchema method will be called two tim…
c6d52e7 
…es (apache#13163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

@michaeljmarshall michaeljmarshall michaeljmarshall approved these changes

@sijie sijie Awaiting requested review from sijie

@congbobo184 congbobo184 Awaiting requested review from congbobo184

@eolivelli eolivelli Awaiting requested review from eolivelli

Assignees

@mattisonchao mattisonchao

Labels
area/client doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mattisonchao @Anonymitaet @codelipenghui @RobertIndie @michaeljmarshall