[broker] Optimize TopicPolicies#messageTTLInSeconds with HierarchyTopicPolicies #13241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Dec 11, 2021
codelipenghui
requested review from
merlimat,
michaeljmarshall,
eolivelli,
315157973,
gaoran10 and
hangc0276
315157973
approved these changes
Dec 12, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…icPolicies (apache#13241) ### Motivation This is one of the serial topic policy optimization with `HierarchyTopicPolicies`. Update topic policy with HierarchyTopicPolicies comes with these benefits: - All topic policy related settings will goes into AbstractTopic#topicPolicies, easier to understand, check, review, and modify. - Unify policy update to AbstractTopic. And easier to find which policy is not applied to non-persistent topic yet. And we can easily add support for it. - Unify policy value with 3 level settings (topic/namespace/broker), and priority with topic > namespace > broker. And it's easier to find which level settings is missing. - All values are updated at creation or by trigger. We can save some resource to update it or recalculate each time we use it. - etc. ### Modifications Add new field `messageTTLInSeconds` in org.apache.pulsar.broker.service.AbstractTopic#topicPolicies. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as - class org.apache.pulsar.broker.admin.TopicMessageTTLTest - org.apache.pulsar.client.api.KeySharedSubscriptionTest#testContinueDispatchMessagesWhenMessageTTL - org.apache.pulsar.broker.stats.PrometheusMetricsTest#testPerTopicExpiredStat - org.apache.pulsar.client.impl.TopicsConsumerImplTest#testDefaultBacklogTTL Some checklist for updating topic policy with `HierarchyTopicPolicies`.
23 tasks
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is one of the serial topic policy optimization with
HierarchyTopicPolicies.Update topic policy with HierarchyTopicPolicies comes with these benefits:
Modifications
Add new field
messageTTLInSecondsin org.apache.pulsar.broker.service.AbstractTopic#topicPolicies.Verifying this change
This change is already covered by existing tests, such as
Some checklist for updating topic policy with
HierarchyTopicPolicies.Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docCode optimization.