-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Support arm64 optimized CRC32c hardware-instructions #13246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
force-pushed
the
support-arm-crc32c
branch
from
December 12, 2021 06:23
430c96a
to
94ae6cb
Compare
Look like the |
Here is a simple benchmark for arm64 instructions optimized and software implementation. TEST(ClientTest, testSwHwArmChecksumBench) {
std::string data = "This is a simple benchmark for CRC32C hardware and software implementation.";
int times = 100000;
clock_t startTime,endTime;
uint32_t hwArmChecksum;
startTime = clock();
for(int i = 0; i < times; i++) {
hwArmChecksum = crc32cHwArm(0, (char *)data.c_str(), data.length());
}
endTime = clock();
LOG_INFO("Crc32cHwArm run time is: " << endTime - startTime << " ms");
uint32_t swChecksum;
startTime = clock();
for(int i = 0; i < times; i++) {
swChecksum = crc32cSw(0, (char *)data.c_str(), data.length());
}
endTime = clock();
LOG_INFO("Crc32cSw run time is: " << endTime - startTime << " ms");
} Result:
The arm64 hardware-instructions implementation is 6 times faster than the software implementation. |
Demogorgon314
force-pushed
the
support-arm-crc32c
branch
from
December 12, 2021 14:45
94ae6cb
to
dd5c2b5
Compare
merlimat
approved these changes
Dec 12, 2021
/pulsarbot run-failure-checks |
merlimat
added
component/c++
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
labels
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc-not-needed
Your PR changes do not impact docs
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add arm64 optimized crc32c instructions support to optimize arm64 performance.
Modifications
Add arm64 optimized crc32c instructions support.
Verifying this change
Documentation
Need to update docs?
no-need-doc