[Java Client] Improve consumer listener logic #13273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
area/client
type/cleanup
michaeljmarshall
requested review from
Technoboy-,
codelipenghui and
BewareMyPower
1 task
codelipenghui
approved these changes
Dec 14, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Dec 22, 2021
* [Java Client] Improve consumer listener logic * Move isListenerHandlingMessage update to before submitting to executor (cherry picked from commit 9f46c4a)
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Dec 29, 2021
* [Java Client] Improve consumer listener logic * Move isListenerHandlingMessage update to before submitting to executor
michaeljmarshall
added a commit
that referenced
this pull request
Mar 30, 2022
* [Java Client] Improve consumer listener logic * Move isListenerHandlingMessage update to before submitting to executor (cherry picked from commit 9f46c4a)
michaeljmarshall
added
cherry-picked/branch-2.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #13023, we updated the Java client's consumer listener logic to ensure correct ordering of messages received. We can simplify the logic for the variable named
executorQueueSize. It can bevolatileinstead ofatomicand it can be a boolean instead of an integer.Modifications
executorQueueSizetoisListenerHandlingMessageinConsumerBaseand make itvolatileinstead ofAtomicinternalPinnedExecutorinConsumerImplVerifying this change
This is a trivial change.
Does this pull request potentially affect one of the following parts:
This is not a breaking change.
Documentation
no-need-docThis is an internal change.