Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transaction] Delete the redundant code #13327

Merged
merged 4 commits into from
Dec 17, 2021
Merged

[Transaction] Delete the redundant code #13327

merged 4 commits into from
Dec 17, 2021

Conversation

liangyepianzhou
Copy link
Contributor

Motivation

The problem was resolved, so there is no need to add a wait and retry method again.

Modification

  1. Delete the redundant code
  2. Optimize some code form

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

### Motivation
The problem was resolved, so there is no need to add a wait and retry method again.
### Modification
1. Delete the redundant code
2. Optimize some code form
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 15, 2021
@liangyepianzhou
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.10.0 milestone Dec 17, 2021
@congbobo184 congbobo184 merged commit fbe0103 into apache:master Dec 17, 2021
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
### Motivation
The problem was resolved, so there is no need to add a wait and retry method again.
### Modification
1. Delete the redundant code
2. Optimize some code form
codelipenghui pushed a commit that referenced this pull request Dec 21, 2021
The problem was resolved, so there is no need to add a wait and retry method again.
1. Delete the redundant code
2. Optimize some code form

(cherry picked from commit fbe0103)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/transaction cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.9.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants