Replace serveral deprecated api usages #13351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codelipenghui @lhotari @michaeljmarshall @merlimat @315157973 PTAL, thanks |
315157973
pushed a commit
to 315157973/pulsar
that referenced
this pull request
Dec 16, 2021
…ect (apache#11446)  befoe this PR precise publish rate limiting wasn't taking effect at all ### Modifications In order to solve the current problems, there are 2 modifications 1. Using IsDispatchRateLimiting in precise publish rate limiter as well (in order to starve the producer) 2. Checking if there are available permits before resetting the read from the connection again ### Verifying this change Already covered by current tests. (cherry picked from commit 00ad07d)
codelipenghui
approved these changes
Dec 16, 2021
nicoloboschi
approved these changes
Dec 16, 2021
merlimat
approved these changes
Dec 16, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
shyamvyas5
pushed a commit
to pandio-com/pulsar
that referenced
this pull request
Dec 20, 2021
…ect (apache#11446)  befoe this PR precise publish rate limiting wasn't taking effect at all In order to solve the current problems, there are 2 modifications 1. Using IsDispatchRateLimiting in precise publish rate limiter as well (in order to starve the producer) 2. Checking if there are available permits before resetting the read from the connection again Already covered by current tests. (cherry picked from commit 00ad07d)
pgier
pushed a commit
to pgier/pulsar
that referenced
this pull request
Jan 6, 2022
…ect (apache#11446)  befoe this PR precise publish rate limiting wasn't taking effect at all ### Modifications In order to solve the current problems, there are 2 modifications 1. Using IsDispatchRateLimiting in precise publish rate limiter as well (in order to starve the producer) 2. Checking if there are available permits before resetting the read from the connection again ### Verifying this change Already covered by current tests.
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 26, 2022
…ect (apache#11446)  befoe this PR precise publish rate limiting wasn't taking effect at all In order to solve the current problems, there are 2 modifications 1. Using IsDispatchRateLimiting in precise publish rate limiter as well (in order to starve the producer) 2. Checking if there are available permits before resetting the read from the connection again Already covered by current tests. (cherry picked from commit 00ad07d) (cherry picked from commit 06c6adf)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…ect (apache#11446)  befoe this PR precise publish rate limiting wasn't taking effect at all ### Modifications In order to solve the current problems, there are 2 modifications 1. Using IsDispatchRateLimiting in precise publish rate limiter as well (in order to starve the producer) 2. Checking if there are available permits before resetting the read from the connection again ### Verifying this change Already covered by current tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Replace serveral deprecated api usages
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doctrival changes, no need doc