[C++] Adjust clang-format search names #13369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
Anonymitaet
reviewed
Dec 20, 2021
BewareMyPower
approved these changes
Dec 20, 2021
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
Anonymitaet
approved these changes
Dec 20, 2021
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Dec 29, 2021
* Adjust clang-format search names * Update pulsar-client-cpp/README.md Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com> Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Pulsar C++ client use
clang-format5.0 to format files, we don't need to search for a version lower than 5.0.Additionally, the old version of clang-format might be hard to install in the normal way, for example, in macOS, users can't use brew to install clang-format@5, because brew doesn't maintain the old version software with very few users. In this PR, it introduced a solution to install
clang-format@5in macOS.Modifications
Documentation
Need to update docs?
doc