Change ContextClassLoader to NarClassLoader in AdditionalServlet #13501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot rerun-failure-checks |
BewareMyPower
requested review from
tuteng,
BewareMyPower,
codelipenghui,
eolivelli,
hangc0276 and
Technoboy-
|
Could you add a test to verify this change? |
|
@BewareMyPower I will do that. |
|
I have added test. |
codelipenghui
approved these changes
Dec 30, 2021
BewareMyPower
approved these changes
Dec 30, 2021
2 tasks
Jason918
approved these changes
Jan 1, 2022
Demogorgon314
approved these changes
Jan 1, 2022
wuzhanpeng
pushed a commit
to wuzhanpeng/pulsar
that referenced
this pull request
Jan 5, 2022
…che#13501) ### Motivation It's ``AddtionalServlet`` side change, like apache#11270 ### Modifications Change context class loader through Thread.currentThread().setContextClassLoader(classLoader) before every protocol handler callback, and change it back to original class loader afterwards.
codelipenghui
pushed a commit
that referenced
this pull request
Jan 6, 2022
) ### Motivation It's ``AddtionalServlet`` side change, like #11270 ### Modifications Change context class loader through Thread.currentThread().setContextClassLoader(classLoader) before every protocol handler callback, and change it back to original class loader afterwards. (cherry picked from commit 40ac793)
codelipenghui
pushed a commit
that referenced
this pull request
Jan 10, 2022
) ### Motivation It's ``AddtionalServlet`` side change, like #11270 ### Modifications Change context class loader through Thread.currentThread().setContextClassLoader(classLoader) before every protocol handler callback, and change it back to original class loader afterwards. (cherry picked from commit 40ac793)
liudezhi2098
pushed a commit
to liudezhi2098/pulsar
that referenced
this pull request
Jan 11, 2022
…tor (apache#13589) ### Motivation It's ``BrokerInterceptor`` side change, like apache#13501 ### Modifications Change context class loader through Thread.currentThread().setContextClassLoader(classLoader) before every interceptor handler callback, and change it back to original class loader afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's
AddtionalServeltside change, like #11270Modifications
Change context class loader through Thread.currentThread().setContextClassLoader(classLoader) before every protocol handler callback, and change it back to original class loader afterwards.
Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc