-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Client] Fix send chunking message failed when ordering key is set. #13699
[Client] Fix send chunking message failed when ordering key is set. #13699
Conversation
@gaoran10 @MarvinCai @codelipenghui This is similar to the fix with schemaVersion #12720. PTAL |
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
@RobertIndie Please also help review this PR. |
From my perspective, it's so terrible to have all these issues just because all chunks share the same I also realized this potential issue when I implement the chunking message feature for C++ client, so I do the deep copy for the initial implementation. Though for the sake of overhead of bytes copy, this solution looks good. But does it really affect? So I won't approve but I won't request changes as well. |
Yes, it's better to do it this way in the first implementation of chunking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Master Issue: #13688
Motivation
The root cause is the same as #13688. Chunking messages share the same metadata. And the type of ordering key is bytebuf, which can not be serialized twice.
Modifications
Reset the field before sending.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc
bug fix