[Transaction] Fix individual ack with transaction decrease unAckMessageCounnt #14020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
codelipenghui,
eolivelli,
merlimat and
gaoran10
congbobo184
added
component/transaction/coordinator
area/transaction
and removed
component/transaction/coordinator
labels
|
@congbobo184:Thanks for your contribution. For this PR, do we need to update docs? |
congbobo184
added
doc-not-needed
|
@congbobo184:Thanks for providing doc info! |
Technoboy-
approved these changes
Jan 29, 2022
codelipenghui
approved these changes
Jan 29, 2022
gaoran10
reviewed
Jan 29, 2022
Comment on lines
479
to
488
| if (isAcknowledgmentAtBatchIndexLevelEnabled) { | ||
| long[] cursorAckSet = getCursorAckSet(position); | ||
| if (cursorAckSet != null) { | ||
| ackedCount = batchSize - BitSet.valueOf(cursorAckSet).cardinality(); | ||
| } else { | ||
| ackedCount = batchSize; | ||
| } | ||
| } else { | ||
| ackedCount = batchSize; | ||
| } |
There was a problem hiding this comment.
LGTM, a little suggestion. Could we reuse this code block for methods individualAckNormal and individualAckWithTransaction?
gaoran10
approved these changes
Jan 29, 2022
added 2 commits
January 30, 2022 01:20
…ding_ack_reduce_unack_message_count
| @@ -249,6 +246,63 @@ public void produceAbortTest() throws Exception { | |||
| log.info("finished test partitionAbortTest"); | |||
| } | |||
|
|
|||
| @Test(dataProvider="enableBatch") | |||
| private void testAckWithTransactionReduceUnAckMessageCount(boolean enableBatch) throws Exception { | |||
There was a problem hiding this comment.
The test should enable batch index ack for the broker and the consumer?
There was a problem hiding this comment.
TransactionTestBase has enable batch index ack
codelipenghui
pushed a commit
that referenced
this pull request
Jan 30, 2022
…geCounnt (#14020) link #13383 ## Motivation #13383 has fixed the batch message ack does not decrease the unacked-msg count, but ack with transaction don't fix because decrease unAckMessageCount move to another method. ack with transaction can't decrease unackMessageCount. (cherry picked from commit 1e2ff8a)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…geCounnt (apache#14020) link apache#13383 ## Motivation apache#13383 has fixed the batch message ack does not decrease the unacked-msg count, but ack with transaction don't fix because decrease unAckMessageCount move to another method. ack with transaction can't decrease unackMessageCount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link #13383
Motivation
#13383 has fixed the batch message ack does not decrease the unacked-msg count, but ack with transaction don't fix
because decrease unAckMessageCount move to another method. ack with transaction can't decrease unackMessageCount.
Modifications
change ack with transaction decrease unackMessageCount to normal ack(ack no transaction).
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)