Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unack message count for transaction Ack while disabled batch index ack #14071

Merged

Commits on Jan 30, 2022

  1. Fix unack message count for transaction Ack while disabled batch inde…

    …x ack.
    
    ### Motivation
    
    Fix unack message count for transaction Ack while disabled batch index ack.
    
    Transaction Ack is different with normal message ack for a batch message.
    
    For normal message, we are using a bitset to carry the batch index state, for example
    
    ```
    1. Ack with `00111111` means acks batch index 0 and 1
    2. For ack batch index 2 and 3, the client will send `00001111` to broker
    3. After all the batch been acked, send `00000000` to broker
    ```
    
    The following is for transaction ack:
    
    ```
    1. `00111111` means acks batch index 0 and 1
    1. `11001111` means acks batch index 2 and 3
    ```
    
    ### Verification
    
    Enabled transaction e2e test for batch index ack disabled
    codelipenghui committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    a3d7881 View commit details
    Browse the repository at this point in the history
  2. Fix checkstyle

    codelipenghui committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    c8c267c View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Apply comment

    codelipenghui committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    add5041 View commit details
    Browse the repository at this point in the history
  2. Apply comment

    codelipenghui committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    db2731f View commit details
    Browse the repository at this point in the history
  3. Fix test.

    codelipenghui committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    e39cdc5 View commit details
    Browse the repository at this point in the history
  4. Fix test.

    codelipenghui committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    87b3636 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Fix test.

    codelipenghui committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    6346dcb View commit details
    Browse the repository at this point in the history
  2. Fix test.

    codelipenghui committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    65f26b4 View commit details
    Browse the repository at this point in the history