[Issue 12774][metadata] Fix race condition in PulsarLedgerIdGenerator#generateShortLedgerId #14118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gerIdGenerator#generateShortLedgerId
Jason918
requested review from
lhotari,
315157973,
merlimat and
codelipenghui
lhotari
reviewed
Feb 4, 2022
...ar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerIdGenerator.java
Show resolved
Hide resolved
merlimat
approved these changes
Feb 4, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Feb 5, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…#generateShortLedgerId (apache#14118) * Fix race condition in org.apache.pulsar.metadata.bookkeeper.PulsarLedgerIdGenerator#generateShortLedgerId * restore testDoNotReplicateSystemTopic * fix BadVersionException check in createHOBPathAndGenerateId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12774
Motivation
See #12774
The root cause is there are multi threads calling
PulsarLedgerIdGenerator#generateLedgerId-->#generateShortLedgerId-->store.put(shortIdGenPath,...). The first success, and the rest fails with exception.Modifications
Skip the exception when the path
shortIdGenPathalready created by others.Verifying this change
This change is already covered by existing tests, such as ReplicatorTest.testDoNotReplicateSystemTopic
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc