Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Remove net.jodah.failsafe dependency (fix JDK17 build) #14124

Merged
merged 4 commits into from
Feb 4, 2022

Conversation

nicoloboschi
Copy link
Contributor

@nicoloboschi nicoloboschi commented Feb 4, 2022

Motivation

Java compiler fails due to a weird exception ClosedFileSystemException. The cause is the usage of net.jodah.failsafe (I haven't found any doc/issue on the failsafe repo, but still)

Modifications

  • Replaced the usage with Awaitility

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 4, 2022
@nicoloboschi nicoloboschi changed the title [build] Upgrade failsafe (fix JDK17 build) [build] Remove net.jodah.failsafe dependency (fix JDK17 build) Feb 4, 2022
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@merlimat merlimat merged commit 4e29a1e into apache:master Feb 4, 2022
@merlimat merlimat added this to the 2.10.0 milestone Feb 4, 2022
nicoloboschi added a commit to datastax/pulsar that referenced this pull request Feb 23, 2022
…e#14124)

* [build] Upgrade failsafe (fix jdk17 build)

* [build] Upgrade failsafe (fix jdk17 build)

* move to awaitility

* move to awaitility

(cherry picked from commit 4e29a1e)
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
…e#14124)

* [build] Upgrade failsafe (fix jdk17 build)

* [build] Upgrade failsafe (fix jdk17 build)

* move to awaitility

* move to awaitility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants