[Pulsar-Perf] Allow configuring metadataStoreUrl in pulsar-perf managed-ledger
#14145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…naged-ledger` Motivation `zookeeperServers` need to be renamed to `metadataStoreUrl` Modifications * Add `metadataStoreUrl` parameter to ManagedLedgerWriter of the pulsar perf. Signed-off-by: Zike Yang <zkyang@streamnative.io>
github-actions
bot
added
the
doc-required
merlimat
reviewed
Feb 7, 2022
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/ManagedLedgerWriter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Zike Yang <zkyang@streamnative.io>
Signed-off-by: Zike Yang <zkyang@streamnative.io>
RobertIndie
added a commit
to RobertIndie/pulsar
that referenced
this pull request
Feb 8, 2022
…dger` Add doc for apache#14145 Signed-off-by: Zike Yang <zkyang@streamnative.io>
1 task
gaoran10
reviewed
Feb 8, 2022
| ClientConfiguration bkConf = new ClientConfiguration(); | ||
| bkConf.setUseV2WireProtocol(true); | ||
| bkConf.setAddEntryTimeout(30); | ||
| bkConf.setReadEntryTimeout(30); | ||
| bkConf.setThrottleValue(0); | ||
| bkConf.setNumChannelsPerBookie(arguments.maxConnections); | ||
| bkConf.setZkServers(arguments.zookeeperServers); | ||
| bkConf.setMetadataServiceUri(arguments.metadataStoreUrl); |
There was a problem hiding this comment.
It seems that only the param arguments.metadataStoreUrl is valid, right?
| @@ -151,6 +156,12 @@ public static void main(String[] args) throws Exception { | |||
| PerfClientUtils.exit(-1); | |||
| } | |||
|
|
|||
| if (arguments.metadataStoreUrl == null && arguments.zookeeperServers == null) { | |||
There was a problem hiding this comment.
Does the param arguments.zookeeperServers still be useful?
There was a problem hiding this comment.
Yes, we need to make it backward compatible.
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/ManagedLedgerWriter.java
Show resolved
Hide resolved
Signed-off-by: Zike Yang <zkyang@streamnative.io>
Jason918
approved these changes
Feb 8, 2022
Anonymitaet
reviewed
Feb 8, 2022
| public String zookeeperServers; | ||
|
|
||
| @Parameter(names = {"-md", | ||
| "--metadata-store"}, description = "Metadata store service url. eg: zk:my-zk:2181") |
There was a problem hiding this comment.
Suggested change
| "--metadata-store"}, description = "Metadata store service url. eg: zk:my-zk:2181") | |
| "--metadata-store"}, description = "Metadata store service URL. For example: zk:my-zk:2181") |
Please capitalize proper nouns correctly. Details: https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.je5thtkj42cb
Anonymitaet
added
doc
codelipenghui
approved these changes
Feb 8, 2022
merlimat
approved these changes
Feb 8, 2022
Anonymitaet
added
the
doc-complete
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…naged-ledger` (apache#14145) * [Pulsar-Perf] Allow configuring `metadataStoreUrl` in `pulsar-perf managed-ledger` Motivation `zookeeperServers` need to be renamed to `metadataStoreUrl` Modifications * Add `metadataStoreUrl` parameter to ManagedLedgerWriter of the pulsar perf. Signed-off-by: Zike Yang <zkyang@streamnative.io> * Make zookeeperServers hidden. Signed-off-by: Zike Yang <zkyang@streamnative.io> * Add null checker. Signed-off-by: Zike Yang <zkyang@streamnative.io> * Add deprecated. Signed-off-by: Zike Yang <zkyang@streamnative.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #13760
Motivation
As per #13760,
zookeeperServersneed to be renamed tometadataStoreUrl.Modifications
metadataStoreUrlparameter to ManagedLedgerWriter of the pulsar perf.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
doc-required