Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broker] Set default value of applied to false on topic policy #14181

Merged
merged 1 commit into from
Feb 10, 2022
Merged

[Broker] Set default value of applied to false on topic policy #14181

merged 1 commit into from
Feb 10, 2022

Conversation

yuruguo
Copy link
Contributor

@yuruguo yuruguo commented Feb 9, 2022

Motivation

The default value of applied on topic policy is false in admin cli, and correspondingly we should also set the default value of applied to false on the server side, which can avoid the problem of operating the topic policy through the rest api without setting applied.

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 9, 2022
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It's better to set explicit default value like this.

@codelipenghui codelipenghui added this to the 2.10.0 milestone Feb 10, 2022
@codelipenghui codelipenghui merged commit d460f09 into apache:master Feb 10, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants