fix rackaware placement policy does not take effect after delete rack configuration #14248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aloyszhang:Thanks for your contribution. For this PR, do we need to update docs? |
|
@aloyszhang:Thanks for providing doc info! |
github-actions
bot
added
doc-not-needed
|
/pulsarbot run-failure-checks |
eolivelli
reviewed
Feb 12, 2022
...r-common/src/main/java/org/apache/pulsar/bookie/rackawareness/BookieRackAffinityMapping.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/RackAwareTest.java
Show resolved
Hide resolved
...r-common/src/main/java/org/apache/pulsar/bookie/rackawareness/BookieRackAffinityMapping.java
Outdated
Show resolved
Hide resolved
hangc0276
reviewed
Feb 14, 2022
...r-common/src/main/java/org/apache/pulsar/bookie/rackawareness/BookieRackAffinityMapping.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
hangc0276
approved these changes
Feb 15, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
1 task
aloyszhang
added a commit
to aloyszhang/pulsar
that referenced
this pull request
Nov 30, 2022
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14247
Motivation
fix rack aware placement policy does not take effect after deleting rack configuration
Modifications
Verifying this change
This change added tests and can be verified as follows:
RackAwareTest.testRackUpdate()Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
no-need-doc(Please explain why)